Drop "Serializable" from the Event Listener interfaces

Description

All interfaces defining the event listeners, such as org.hibernate.event.spi.PostDeleteEventListener and several more in the same package, are currently extending java.io.Serializable.

We should no longer extend it, not least as it has no real consequence on the implementations unless they implement it correctly.

Environment

None

Activity

Show:
Sanne Grinovero
August 13, 2018, 9:47 AM

Hi , thanks for offering to help on this!

Keep in mind though that the master branch is currently `5.4` and this might be a breaking change for some, we should not apply this change unless we're sure this branch becomes 6 soon.

Alvaro Pedraza
August 13, 2018, 2:05 PM

Hi, does that means to hold the PR until the 6.0 tag appears? AFAIK, the different versions are marked as tags in the master branch, am I correct?

BTW, I'm not able to mention any user in JIRA, is this due to my external contributor role? do I need some special permission to do that?

Thanks in advance for your time

Sanne Grinovero
August 14, 2018, 8:51 AM

Hi Alvaro,
yes it means I'm not sure. We think it will be likely we'll rename 5.4 as 6 but this is not decided yet. Until that's decided such a change can not be merged in master so I would suggest to not work on this yet.

Assignee

Alvaro Pedraza

Reporter

Sanne Grinovero

Fix versions

Labels

None

backPortable

None

Suitable for new contributors

None

Requires Release Note

None

Pull Request

None

backportDecision

None

Components

Priority

Major
Configure