Uploaded image for project: 'Hibernate ORM'
  1. HHH-12622

JdbcResourceLocalTransactionCoordinatorImpl#markRollbackOnly should be ignored if there is no TX

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 5.3.0.Final
    • Fix Version/s: 5.3.1
    • Component/s: hibernate-core
    • Labels:
      None
    • Bug Testcase Reminder (view):

      Bug reports should generally be accompanied by a test case!

    • Last commented by a user?:
      true
    • Sprint:

      Description

      [1] shows the call stack of how JdbcResourceLocalTransactionCoordinatorImpl#markRollbackOnly can be called without an TX but still sets rollbackOnly to true. We should ignore this call if there is no TX.

      Change markRolbackOnly to also check if tx status is NOT_ACTIVE. Currently, we are checking getStatus() != TransactionStatus.ROLLED_BACK which is not enough, as we shouldn't set the rollbackOnly flag if tx status is NOT_ACTIVE.

      [1] https://paste.fedoraproject.org/paste/t6V1x7tXZMx1mX4RLmG3wg

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: