Update to JBossStandAloneJtaPlatform should be backward compatible attempting old names as well

Description

During the class and method names expected to be looked up by JBossStandAloneJtaPlatform have been updated to use more recent WildFly JTA clients, but this broke backward compatibility.

We should at least try to fallback to using the older names.

Environment

None

Activity

Show:
Sanne Grinovero
May 30, 2018, 12:46 PM

+1 to keep it, that would allow people to pick one explicitly rather than having to necessarily rely on some logic.

But will you be able to automatically detect which one to use by default? Like it used to automatically pick one for JBossStandAloneJtaPlatform - I'm not sure how that works but it's a nice touch.

Regarding extending an existing type: I guess it doesn't matter much. Feel free to extend it if that makes the code more maintainable.

Scott Marlow
May 30, 2018, 2:36 PM

By default, I think we should continue to use JBossStandAloneJtaPlatform. The WildFlyStandAloneJtaPlatform could be specified in applications written against 5.3.1+. I suppose that we could deprecate the WildFlyStandAloneJtaPlatform and link back to JBossStandAloneJtaPlatform, so that WildFlyStandAloneJtaPlatform could be removed.

Guillaume Smet
June 22, 2018, 4:54 PM

what's the exact status of this one?

I see one PR merged and another unmerged? Can we merge it and close this issue?

Thanks!

Scott Marlow
June 22, 2018, 5:10 PM
Edited

Just waiting for a review of https://github.com/hibernate/hibernate-orm/pull/2317 (see updated description + recent comment).

Guillaume Smet
June 22, 2018, 5:30 PM

OK, thanks for the status . Keeping it for 5.3.2 then.

Assignee

Scott Marlow

Reporter

Sanne Grinovero

Fix versions

Labels

None

backPortable

None

Suitable for new contributors

None

Requires Release Note

None

Pull Request

None

backportDecision

None

Affects versions

Priority

Critical
Configure