Pass BootstrapContext to Integrator#integrate

Description

E.g.:

We should decide this for Alpha1 as it helps integrators more easily test this. And as this is changing a signature that has been stable since 4.0 that is important. We could also just add an overload:

Should we consider adding a "parameter object" argument instead?

Environment

None

Activity

Show:
Steve Ebersole
November 6, 2018, 4:53 PM
Edited

Relatedly, I wonder if there are implementors of `#integrate` during which things expecting the TypeConfiguration to be scoped to the SessionFactory would break. Maybe we should allow a TypeConfiguration to be simultaneously scoped by both during this transition. Thoughts?

Steve Ebersole
November 7, 2018, 2:20 AM
Steve Ebersole
May 7, 2019, 9:52 PM

Let me know if you see anything we should improve here

Yoann Rodière
May 9, 2019, 7:38 AM
Edited

Thanks; I just checked and it worked fine. The double default method allowed a smooth transition, too.

The Search 6 + ORM 6 build still fails, but that's related to other features that are not yet implemented in ORM 6 (mostly some types of associations, I think). So, not related to this ticket

EDIT: the test results: http://ci.hibernate.org/view/Search/job/hibernate-search-yoann/job/tracking-orm6.0-master/52/testReport/

Assignee

Steve Ebersole

Reporter

Steve Ebersole

Fix versions

Labels

backPortable

None

Suitable for new contributors

None

Requires Release Note

None

Pull Request

None

backportDecision

None

Priority

Major
Configure