We're updating the issue view to help you get more done. 

Apply dialect checks from both method and class level.

Description

The CustomRunner used by ORM applies a mutual exclusive lookup when inspecting annotations like the @RequiresDialectFeature annotation. This meant that if a dialect feature requirement on the method successfully passed but the class had a requirement that would have failed; the test was actually executed anyway, which lead to some inconsistent behavior with tests after changes were made to the test suite to support HHH-13104.

In short, the CustomRunner check should not apply a mutual exclusive lookup but rather gather the annotations from both the method and the class and check that all found annotations pass the check and in the event at least one fails; the method should be considered Ignored.

Environment

None

Status

Assignee

Chris Cranford

Reporter

Chris Cranford

Fix versions

Labels

None

backPortable

None

Suitable for new contributors

None

Requires Release Note

None

Pull Request

None

backportDecision

None

Components

Affects versions

5.4.0

Priority

Major