IdentifierLoadAccessImpl and MultiIdentifierLoadAccessImpl fails when RootGraph is set.

Description

Hibernate ORM 5.4 introduces support of RootGraphs for IdentifierLoadAccess and MultiIdentifierLoadAccess, user could specify a load graph and a graph semantic using method

When query is executed, we check if GraphSemantic is present. If it is set but no load graph was supplies exception is thrown. (SessionImpl:2851, SessionImpl:3050 ).
Currently this code looks like

But, this seems to be incorrect. We should check if rootGraph is null, but not otherwise. The correct version is:

This makes using RootGraphs with multiload impossible.

Environment

None

Activity

Show:
Gail Badner
March 20, 2019, 7:16 AM

, , I merged the PR.

Should a new issue be opened to deal with MultiIdentifierLoadAccessImpl?

Andrea Boriero
December 5, 2019, 10:26 AM

@Gail I see a PR was merged a long time ago, so probably we have to close this an open a new one for MultiIdentifierLoadAccessImpl`, what do you think?

 

Assignee

Taras Chaika

Reporter

Taras Chaika

Fix versions

None

Labels

None

backPortable

None

Suitable for new contributors

None

Requires Release Note

None

backportDecision

None

Components

Affects versions

Priority

Major
Configure