Partial revert of string interning introduced by HHH-3924

Description

introduced various string interning cases in QueryLoader, BasicLoader and DefaultEntityAliases.

We should keep interning only when the Strings are long lived, such as when DefaultEntityAliases is being constructed as part of the long-lived metamodel. The other cases are not useful, as the Strings are short lived anyway and are at risk of polluting the String interned table.

Environment

None

Assignee

Sanne Grinovero

Reporter

Sanne Grinovero

Fix versions

Labels

None

backPortable

Backport?

Suitable for new contributors

None

Requires Release Note

None

Pull Request

None

backportDecision

None

Components

Priority

Major
Configure