The JPA 2.2 Query#getResultStream returns a Stream wrapping a Hibernate ScrollableResultsIterator.
However, even if a terminal Stream operation is called, the underlying ScrollableResultsIterator will stay open until the Session is closed.
More, the current implementation does not pass the closeHandler to the IntStream, LongStream, or DoubleStream when calling mapToInt or other methods that return a primitive stream.
We need to create a StreamDecorator, IntStreamDecorator, LongStreamDecorator, and DoubleStreamDecorator that can both delegate the stream calls and close the stream upon executing a terminal operation.
Thanks, for merging it. I’ll write an article about it once 5.4.1 is released.
Hmm, is it me or the PR wasn’t yet merged?
Good catch. I don’t see it merged either also the issue was marked as Fixed.
was it merged to some other branch than the master one?
What is the PR again? Jira is still having trouble talking to GitHub apparently
Ah, no it was not merged. I requested some changes (which you’ve made). I think what confused is that you said “thanks for merging”