improve ActionQueue in minor way to improve its maintainability

Description

During working on HHH-14227, I found there are many minor issues in ActionQueue, including:

  • failure to set LinkedHashMap's constructor parameter correctly;

  • unused temporary variable;

  • unnecessary down casting;

  • unnecessary nullness checking;

  • possible simplification to BatchIdentifier

Given that we have improved the insert ordering testing cases, it is good timing to consider improve ActionQueue, which is important and is definitively a hot spot.

Note that the scope of this ticket only includes minor issue fixing, excluding fundamental sorting refactoring, etc.

Environment

None

Activity

Show:
Sanne Grinovero
October 8, 2020, 7:36 AM

Only a subset of the proposed changes were applied; see the PR for details.

Assignee

Nathan Xu

Reporter

Nathan Xu

Fix versions

Labels

None

backPortable

None

Suitable for new contributors

None

Requires Release Note

None

Pull Request

None

backportDecision

None

Components

Priority

Minor
Configure