Allow Dialect version to be specified separately from the dialect class name
Activity
Show:
Steve Ebersole
changed the StatusDecember 22, 2022 at 10:59 PMResolved
Closed
Christian Beikov
changed the AssigneeSeptember 9, 2022 at 2:51 PMUnassigned
Jan Schatteman
Christian Beikov
changed the StatusSeptember 9, 2022 at 2:51 PMOpen
Resolved
Christian Beikov
updated the Fix versionsSeptember 9, 2022 at 2:51 PMNone
6.2.0
Christian Beikov
updated the ResolutionSeptember 9, 2022 at 2:51 PMNone
Fixed
Jan Schatteman
updated the LinkAugust 11, 2022 at 3:28 PMNone
This issue blocks HHH-15447
Jan Schatteman
updated the DescriptionAugust 10, 2022 at 3:09 PMWe need to be able to specify the dialect version by using the environment settings {{JAKARTA_HBM2DDL_DB_VERSION}}, {{JAKARTA_HBM2DDL_DB_MAJOR_VERSION}}, {{JAKARTA_HBM2DDL_DB_MINOR_VERSION.}} Right now, if the version is specified like this, it is not taken into account.
This would allow replacing something such as
{code:java}cfg.setProperty( AvailableSettings.DIALECT, Oracle10gDialect.class.getName() );{code}
with
{code:java}cfg.setProperty( AvailableSettings.DIALECT, OracleDialect.class.getName() );
cfg.setProperty( AvailableSettings.JAKARTA_HBM2DDL_DB_MAJOR_VERSION, "10" );{code}
NB: once the above is implemented, tests that used these deprecated Dialects, should take special care in assuring that they actually get the requested dialect. (e.g. {{BatchVersionedDataConfigTest }})
We need to be able to specify the dialect version by using the environment settings {{JAKARTA_HBM2DDL_DB_VERSION}}, {{JAKARTA_HBM2DDL_DB_MAJOR_VERSION}}, {{JAKARTA_HBM2DDL_DB_MINOR_VERSION.}} Right now, if the version is specified like this, it is not taken into account.
This would allow replacing something such as
{code:java}cfg.setProperty( AvailableSettings.DIALECT, Oracle10gDialect.class.getName() );{code}
with
{code:java}cfg.setProperty( AvailableSettings.DIALECT, OracleDialect.class.getName() );
cfg.setProperty( AvailableSettings.JAKARTA_HBM2DDL_DB_MAJOR_VERSION, "10" );{code}
NB: once the above is implemented, tests that used these deprecated Dialects, should take special care in assuring that they actually get the requested dialect. (e.g. {{BatchVersionedDataConfigTest.testBatchVersionedDataForOracle10gDialect() }}may pass, even with a version different from the one specified{{ }})
Jan Schatteman
updated the DescriptionAugust 10, 2022 at 3:00 PMWe need to be able to specify the dialect version by using the environment settings {{JAKARTA_HBM2DDL_DB_VERSION}}, {{JAKARTA_HBM2DDL_DB_MAJOR_VERSION}}, {{JAKARTA_HBM2DDL_DB_MINOR_VERSION.}} Right now, if the version is specified like this, it is not taken into account.
This would allow replacing something such as {{cfg.setProperty( AvailableSettings.DIALECT, Oracle10gDialect.class.getName() );}}
with
{code:java}cfg.setProperty( AvailableSettings.DIALECT, OracleDialect.class.getName() );
cfg.setProperty( AvailableSettings.JAKARTA_HBM2DDL_DB_MAJOR_VERSION, "10" );{code}
NB: once the above is implemented, tests that used these deprecated Dialects, should take special care in assuring that they actually get the requested dialect. (e.g. {{BatchVersionedDataConfigTest }})
We need to be able to specify the dialect version by using the environment settings {{JAKARTA_HBM2DDL_DB_VERSION}}, {{JAKARTA_HBM2DDL_DB_MAJOR_VERSION}}, {{JAKARTA_HBM2DDL_DB_MINOR_VERSION.}} Right now, if the version is specified like this, it is not taken into account.
This would allow replacing something such as
{code:java}cfg.setProperty( AvailableSettings.DIALECT, Oracle10gDialect.class.getName() );{code}
with
{code:java}cfg.setProperty( AvailableSettings.DIALECT, OracleDialect.class.getName() );
cfg.setProperty( AvailableSettings.JAKARTA_HBM2DDL_DB_MAJOR_VERSION, "10" );{code}
NB: once the above is implemented, tests that used these deprecated Dialects, should take special care in assuring that they actually get the requested dialect. (e.g. {{BatchVersionedDataConfigTest }})
Jan Schatteman
updated the DescriptionAugust 10, 2022 at 2:59 PMWe need to be able to specify the dialect version by using the environment settings {{JAKARTA_HBM2DDL_DB_VERSION}}, {{JAKARTA_HBM2DDL_DB_MAJOR_VERSION}}, {{JAKARTA_HBM2DDL_DB_MINOR_VERSION.}} Right now, if the version is specified like this, it is not taken into account.
We need to be able to specify the dialect version by using the environment settings {{JAKARTA_HBM2DDL_DB_VERSION}}, {{JAKARTA_HBM2DDL_DB_MAJOR_VERSION}}, {{JAKARTA_HBM2DDL_DB_MINOR_VERSION.}} Right now, if the version is specified like this, it is not taken into account.
This would allow replacing something such as {{cfg.setProperty( AvailableSettings.DIALECT, Oracle10gDialect.class.getName() );}}
with
{code:java}cfg.setProperty( AvailableSettings.DIALECT, OracleDialect.class.getName() );
cfg.setProperty( AvailableSettings.JAKARTA_HBM2DDL_DB_MAJOR_VERSION, "10" );{code}
NB: once the above is implemented, tests that used these deprecated Dialects, should take special care in assuring that they actually get the requested dialect. (e.g. {{BatchVersionedDataConfigTest }})
Jan Schatteman
created the IssueAugust 10, 2022 at 2:52 PMFixed
Details
Assignee
Reporter
Jan Schatteman
Jan SchattemanComponents
Fix versions
Priority
Major
Created August 10, 2022 at 2:52 PM
Updated December 22, 2022 at 10:59 PM
Resolved September 9, 2022 at 2:51 PM
We need to be able to specify the dialect version by using the environment settings
JAKARTA_HBM2DDL_DB_VERSION
,JAKARTA_HBM2DDL_DB_MAJOR_VERSION
,JAKARTA_HBM2DDL_DB_MINOR_VERSION.
Right now, if the version is specified like this, it is not taken into account.This would allow replacing something such as
cfg.setProperty( AvailableSettings.DIALECT, Oracle10gDialect.class.getName() );
with
cfg.setProperty( AvailableSettings.DIALECT, OracleDialect.class.getName() ); cfg.setProperty( AvailableSettings.JAKARTA_HBM2DDL_DB_MAJOR_VERSION, "10" );
NB: once the above is implemented, tests that used these deprecated Dialects, should take special care in assuring that they actually get the requested dialect. (e.g.
)
BatchVersionedDataConfigTest.testBatchVersionedDataForOracle10gDialect()
may pass, even with a version different from the one specified