Allow Dialect version to be specified separately from the dialect class name
Activity
Show:
Fixed
Details
Details
Assignee
Jan Schatteman
Jan SchattemanReporter
Jan Schatteman
Jan SchattemanComponents
Fix versions
Priority
Created August 10, 2022 at 2:52 PM
Updated December 22, 2022 at 10:59 PM
Resolved September 9, 2022 at 2:51 PM
We need to be able to specify the dialect version by using the environment settings
JAKARTA_HBM2DDL_DB_VERSION
,JAKARTA_HBM2DDL_DB_MAJOR_VERSION
,JAKARTA_HBM2DDL_DB_MINOR_VERSION.
Right now, if the version is specified like this, it is not taken into account.This would allow replacing something such as
cfg.setProperty( AvailableSettings.DIALECT, Oracle10gDialect.class.getName() );
with
cfg.setProperty( AvailableSettings.DIALECT, OracleDialect.class.getName() ); cfg.setProperty( AvailableSettings.JAKARTA_HBM2DDL_DB_MAJOR_VERSION, "10" );
NB: once the above is implemented, tests that used these deprecated Dialects, should take special care in assuring that they actually get the requested dialect. (e.g.
)
BatchVersionedDataConfigTest.testBatchVersionedDataForOracle10gDialect()
may pass, even with a version different from the one specified