Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Investigate performance drops

Description

Attachments

2
  • 10 Jan 2024, 09:20 AM
  • 02 Jan 2024, 08:34 AM

Activity

Show:

Thomas HeiglJune 15, 2024 at 12:19 PM

Christian BeikovJune 13, 2024 at 3:48 PM

Yes, please create a new ticket.

Thomas HeiglJune 11, 2024 at 4:16 PM

: I updated my JMH fork with another test-case that uses query caching.

All your work greatly improved the base-case. Hibernate 6 significantly outperforms 5 in the basic test case, but reading from the persistence context and reading from the query cache still seems to be significantly slower:

Benchmark Mode Cnt Score Error Units JPABenchmark.perf5 thrpt 6 84,909 ± 1,796 ops/s JPABenchmark.perf5Cache thrpt 6 480,144 ± 47,284 ops/s JPABenchmark.perf5LargeTransaction thrpt 6 11,051 ± 0,530 ops/s JPABenchmark.perf6 thrpt 6 91,136 ± 3,226 ops/s JPABenchmark.perf6Cache thrpt 6 300,935 ± 10,285 ops/s JPABenchmark.perf6LargeTransaction thrpt 6 7,913 ± 1,104 ops/s

Should I create another ticket?

Thomas HeiglJune 10, 2024 at 5:33 PM

I reran my indexer withhttps://hibernate.atlassian.net/browse/HHH-18154 and it improved performance. Hibernate 6 is now only ~6% slower.

I will try to attach a profiler to my staging environment to see if I can identify other hotspots.

Thomas HeiglMay 24, 2024 at 2:45 PM

: I managed to run our indexer against 6.6.0-SNAPSHOT and I’m seeing some improvements:

5.6: INF MassIndexerImpl Finished updating index in 680s. 6.6: INF MassIndexerImpl Finished updating index in 742s.

We are down to a ~9% performance difference. Still not quite as fast as Hibernate 5 but definitely going in the right direction. thumbs up

Thomas HeiglMay 23, 2024 at 5:52 PM
Edited

These are the relevant classes. I wasn’t able to reproduce the error in a simple unit test though. There must be some additional complexity in my code that causes the issue. I’ll try to get more info next week.

@Embeddable @MappedSuperclass public class Range<T extends Comparable<T> & Serializable> implements Serializable { private T min; private T max; public Range() {} public Range(T min, T max) { this.min = min; this.max = max; } public T getMin() { return min; } public void setMin(@Nullable T min) { this.min = min; } public T getMax() { return max; } public void setMax(@Nullable T max) { this.max = max; } } @Embeddable public class IntegerRange extends Range<Integer> { public IntegerRange() {} public IntegerRange(Integer min, Integer max) { super(min, max); } }

Christian BeikovMay 23, 2024 at 5:31 PM

It seems like you have an @Embeddable class that extends another @Embeddable class or something like that. With ORM 6.6, this uses discriminator inheritance. Please share your model with us so we can fix that before the final 6.6 release.

Thomas HeiglMay 23, 2024 at 11:09 AM

Unfortunately, 6.6.0-SNAPSHOT does not start for me:

It fails to build the MetaModel for a generic embeddable:

Caused by: java.lang.NullPointerException: Cannot invoke "String.equals(Object)" because the return value of "org.hibernate.mapping.Component.getPropertyDeclaringClass(org.hibernate.mapping.Property)" is null at org.hibernate.metamodel.internal.MetadataContext.wrapUp(MetadataContext.java:410) at org.hibernate.metamodel.model.domain.internal.JpaMetamodelImpl.processJpa(JpaMetamodelImpl.java:641) at org.hibernate.metamodel.model.domain.internal.MappingMetamodelImpl.finishInitialization(MappingMetamodelImpl.java:215) at org.hibernate.internal.SessionFactoryImpl.initializeMappingModel(SessionFactoryImpl.java:372) at org.hibernate.internal.SessionFactoryImpl.<init>(SessionFactoryImpl.java:301) at org.hibernate.boot.internal.SessionFactoryBuilderImpl.build(SessionFactoryBuilderImpl.java:457) at org.hibernate.jpa.boot.internal.EntityManagerFactoryBuilderImpl.build(EntityManagerFactoryBuilderImpl.java:1506)

In my case component.getPropertyDeclaringClass( property ) is null.

I won’t be able to provide a reproducer until some time next week, but the comparison should probably be made null-safe.

Christian BeikovMay 23, 2024 at 10:09 AM

We plan to do the release soon, but please test the nightly version.

Thomas HeiglMay 22, 2024 at 7:44 PM

Great news ! Is there another 6.6.0 release planned in the next days or should I test a nightly build?

Christian BeikovMay 22, 2024 at 5:35 PM

Let me know if https://github.com/hibernate/hibernate-orm/pull/8413 improves your results. https://hibernate.atlassian.net/browse/HHH-18154 should hopefully fix the issue fully.

Fixed

Details

Assignee

Reporter

Sprint

Fix versions

Priority

Created August 3, 2023 at 12:29 PM
Updated June 15, 2024 at 12:19 PM
Resolved May 22, 2024 at 6:01 PM

Flag notifications