param values in generator element should be trimmed during HbmBinding

Description

When using IDEs or tools like xdoclet to generate HBM files, it is easy to get XML like this:

<generator class="sequence">
<param
name="sequence"
>
SEQ_SOME_SEQUENCE
</param>
</generator>

However the SchemaValidator barfs on this because the HbmBinder does not trim the sequence name.
The fix is similar to the fix for I believe, i.e. in HbmBinder.java in method makeIdentifier(...), use getTextTrim() instead of getText().
In 3.1 branch, this is at line 1902. On trunk this is line 1990.

Environment

Oracle 10g, JDK 1.5.0_06, linux, hibernate 3.1.3

Activity

Show:
Max Rydahl Andersen
October 9, 2006, 10:24 AM

I just commented on the 3.1.4 release planned question and the wrong assumption about 3.2 and annotations. Not about the quality of the fix.

Renaud Bruyeron
January 17, 2007, 7:08 PM

Hello,

I was wondering if this issue fell through the gaps? 3.2.1GA still has this issue. The patch is a trivial one-liner, I can't see any reason not to apply it.

Diego Plentz
October 28, 2007, 6:51 PM

Fixed in 3.2 branch / trunk.

Gail Badner
October 29, 2007, 9:35 PM

I added 3.3 as another fix version, since it was also committed to trunk.

Steve Ebersole
March 21, 2011, 7:06 PM

Bulk closing stale resolved issues

Assignee

Diego Plentz

Reporter

Renaud Bruyeron

Fix versions

Labels

None

backPortable

None

Suitable for new contributors

None

Requires Release Note

None

Pull Request

None

backportDecision

None

Components

Affects versions

Priority

Major
Configure