Callable update/insert/delete statements should not force rowcount out parameter in AbstractEntityPersister

Description

It appears as though callable statements in DB2 for AbstractCollectionPersister was resolved under HHH-1792; however, the AbstractEntityPersister was not changed to use the new Expectations class instead of the check function. The check function call in "delete(final Serializable id, final Object version, final int j, final Object object, final String sql, final SessionImplementor session) throws HibernateException" and "update(final Serializable id, final Object[] fields, final Object[] oldFields, final Object rowId, final boolean[] includeProperty, final int j, final Object oldVersion, final Object object, final String sql, final SessionImplementor session) throws HibernateException"appears to need to replace with a call to expectation.verifyOutcome().

The insert function does not currently call check. Should it call expectation.verifyOutcome() to be consistent with delete and update implementations.

Snippet of my change for update(final Serializable id, final Object[] fields, final Object[] oldFields, final Object rowId, final boolean[] includeProperty, final int j, final Object oldVersion, final Object object, final String sql, final SessionImplementor session) throws HibernateException:
if ( useBatch ) {
session.getBatcher().addToBatch( expectation );
return true;
}
else {
expectation.verifyOutcome( update.executeUpdate(), update, -1 );
return true;
}

Environment

None

Activity

Show:
Brett Meyer
April 7, 2014, 5:42 PM

In an effort to clean up, in bulk, tickets that are most likely out of date, we're transitioning all ORM 3 tickets to an "Awaiting Test Case" state. Please see http://in.relation.to/Bloggers/HibernateORMJIRAPoliciesAndCleanUpTactics for more information.

If this is still a legitimate bug in ORM 4, please provide either a test case that reproduces it or enough detail (entities, mappings, snippets, etc.) to show that it still fails on 4. If nothing is received within 3 months or so, we'll be automatically closing them.

Thank you!

Brett Meyer
July 8, 2014, 3:11 PM

Bulk rejecting stale issues. If this is still a legitimate issue on ORM 4, feel free to comment and attach a test case. I'll address responses case-by-case. Thanks!

Assignee

Unassigned

Reporter

bradv

Fix versions

None

Labels

None

backPortable

None

Suitable for new contributors

None

Requires Release Note

None

Pull Request

None

backportDecision

None

Affects versions

Priority

Major
Configure