AbstractFlushingEventListener logs errors instead of just throwing an exception

Description

Using Hibernate 3.2.5.ga, the AbstractFlushingEventListener logs errors from line 301 in the performExecutions method any time a HibernateException is thrown within the method. The exception is then propagated upward. In some cases, client code will catch this exception and handle it, and the result is not considered an error. Then Hibernate has incorrectly made an error entry in the logs, which might have spawned an alert email or, worse, woken someone up at 2 AM with a page. Since the exception is propagated upward, there is no reason for Hibernate to log anything at this point. It should be left to client code to decide what to do with it.

Environment

None

Activity

Show:
Steve Ebersole
March 21, 2011, 7:05 PM

Bulk closing stale resolved issues

Duplicate

Assignee

Gail Badner

Reporter

Ryan Stewart

Fix versions

None

Labels

None

backPortable

None

Suitable for new contributors

None

Requires Release Note

None

Pull Request

None

backportDecision

None

Affects versions

Priority

Minor