no matter if you use annotation or mapping files, test will fail using javassist (it used to fail with previous version too)
See attached testcase to reproduce the problem.
testcase the pattern used in hb-core, just using annotations
easy to switch from annotation to mapping files in org.hibernate.test.instrument2.cases.AbstractExecutable (comment/uncomment specific lines in getAnnotatedClasses and getXmlFiles)
the test case with annotations passes if this change applied
this patch (HHH-4614-Javassist.patch) can make the test case attached pass (both HBM and annotations)
I created this patch on trunk
I think your patch is good. It looks like a simple oversight.
Make sure the core test suite still pass though (instrumented).
split this issue
I will create another one focus on cglib later
Bulk closing stale resolved issues