HHH-3659 is only half done, due to HHH-4989 (i.e. no HQL performance log when running Java 5)

Description

introduced a well-deserved HQL execution time log, which is good.
Unfortunately, (Java 5 concurrent for statistics) didn't pick up those changes, so no execution time logs when running Java 5.

To fix, add the same log statement to ConcurrentStatisticsImpl#queryExecuted(String hql, int rows, long time):

May I also suggest that we change this particular logger from whichever implementation class du jour to a org.hibernate.performance logger.

Environment

None

Activity

Show:
Steve Ebersole
August 14, 2010, 1:01 PM

Not going to get into magic string based logger names anymore.

Cédrik LIME
August 17, 2010, 8:41 PM

I understand you want to avoid magic strings.
How about logging to the interface (org.hibernate.stat.Statistics) instead of the implementation for this particular log? This way, you will be able to swap the implementation (which the user shouldn't care about) and keep the public information with no change on the client side.

Fixed

Assignee

Steve Ebersole

Reporter

Cédrik LIME

Fix versions

Labels

None

backPortable

None

Suitable for new contributors

None

Requires Release Note

Affirmative

Pull Request

None

backportDecision

None

Components

Affects versions

Priority

Trivial