FirebirdDialect: invalid limit strings when SQL comments are enabled

Description

When using Hibernate with the Firebird database and configuring hibernate.use_sql_comments=true, the FirebirdDialect inserts the keywords "first" and "skip" at a fixed position in the given SQL clause with the offset 6, which is okay when a plain SQL clause is given so the "select" keyword is always there at the beginning, but produces invalid SQL clauses when commenting inside SQL is enabled.
For example, when I enable comments in my project, the generated SQL is:

I've made a patch that corrects the issue, so e.g. the above example is generated correctly:

The patch and a test case for the issue are attached.

Environment

Hibernate 3.3.1, Firebird 2.1.3

Activity

Show:
Brett Meyer
April 7, 2014, 5:45 PM

In an effort to clean up, in bulk, tickets that are most likely out of date, we're transitioning all ORM 3 tickets to an "Awaiting Test Case" state. Please see http://in.relation.to/Bloggers/HibernateORMJIRAPoliciesAndCleanUpTactics for more information.

If this is still a legitimate bug in ORM 4, please provide either a test case that reproduces it or enough detail (entities, mappings, snippets, etc.) to show that it still fails on 4. If nothing is received within 3 months or so, we'll be automatically closing them.

Thank you!

Brett Meyer
July 8, 2014, 3:12 PM

Bulk rejecting stale issues. If this is still a legitimate issue on ORM 4, feel free to comment and attach a test case. I'll address responses case-by-case. Thanks!

Rejected

Assignee

Unassigned

Reporter

Aleš Smodiš

Fix versions

None

Labels

None

backPortable

None

Suitable for new contributors

None

Requires Release Note

None

Pull Request

None

backportDecision

None

Components

Affects versions

Priority

Major