Integer overflow in setFirstResult() and setMaxResults()

Description

It seems there is an integer overflow bug in pagination APIs... It is very easy to reproduce. If setFirstResult() is greater than 0, and setMaxResults(Integer.MAX_VALUE), the query will return no results. But the moment we set maxResults to (Integer.MAX_VALUE - firstResult), everything works as expected.

Environment

Oracle 10g

Activity

Show:
Kyrill Alyoshin
October 30, 2010, 3:35 AM

Interesting case. It is not reproducible on HSQLDB, but is on Oracle. And it is not a problem with Oracle or the its JDBC driver. Hmm...

Kyrill Alyoshin
October 30, 2010, 4:11 AM

Yep. There is an overflow in org.hibernate.loader.Loader#setMaxRows. Patch is attached.

Kyrill Alyoshin
October 30, 2010, 5:48 AM

Oops. The bug occurs in multiple places in Loader. Here is an updated patch.

Brett Meyer
April 8, 2014, 3:47 AM

In an effort to clean up, in bulk, tickets that are most likely out of date, we're transitioning all ORM 3 tickets to an "Awaiting Test Case" state. Please see http://in.relation.to/Bloggers/HibernateORMJIRAPoliciesAndCleanUpTactics for more information.

If this is still a legitimate bug in ORM 4, please provide either a test case that reproduces it or enough detail (entities, mappings, snippets, etc.) to show that it still fails on 4. If nothing is received within 3 months or so, we'll be automatically closing them.

Thank you!

Brett Meyer
July 9, 2014, 1:12 AM

Bulk rejecting stale issues. If this is still a legitimate issue on ORM 4, feel free to comment and attach a test case. I'll address responses case-by-case. Thanks!

Rejected

Assignee

Unassigned

Reporter

Kyrill Alyoshin

Fix versions

None

Labels

None

backPortable

None

Suitable for new contributors

None

Requires Release Note

None

Pull Request

None

backportDecision

None

Components

Affects versions

Priority

Minor