[HHH-5855] The method "merge" from the EntityManager causes a duplicated "insert" of a child entity. - Hibernate JIRA

Details

Type: Bug
Status: Open
Priority: Critical
Resolution: Unresolved
Affects Version/s: 3.3.1, 3.6.0
Fix Version/s: None
Component/s: annotations, core, entity-manager
Labels:
None
Environment:
Hibernate-Core 3.6.0, Hibernate EntityManager 3.6.0, Derby, Spring 3.0.5 (Configuration), JUnit 4.5

Bug Testcase Reminder (view):

Bug reports should generally be accompanied by a test case!
Last commented by a user?:
true

Description

The method "merge" from the EntityManager causes a duplicated "insert" of a child entity.
Related to ~~HHH-3332~~

Observed Behavior:

When you have an Entity A with a OneToMany(fetch=LAZY, cascade=ALL or (MERGE and PERSIST)) relationship to another Entity B and attempt to add an new B instance to A hibernate will generate a duplicate insert command upon commit.

I have witnessed this problem occurring when this procedure is followed:

retrieve an instance of A from persistence (A a = em.find(A.class, id))
add a new B to A (a.getBs.add(new B()))
merge instance 'a' back into persistence (em.merge(a))

Upon transaction commit hibernate will generate an additional "insert" statement and insert the new instance of b into the data source twice.

Expected behavior:

I would expect hibernate to only perform a single insertion when 'a' is merged back to persistence and the B's are created through the cascade.

Notes (Discoveries):

This problem can be worked around by:

Changing the OneToMany relationship from a List to a Set
Only using either Cascade MERGE or PERSIST not both of ALL
Add a new B to A.getBs by adding to the '0' index (a.getBs.add(0,new B()))

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

CascadeMergeTest.zip

19/Jan/11 1:02 PM

210 kB

Seth Martin
CascadeMergeTest.zip

19/Jan/11 11:28 AM

6 kB

Seth Martin
Hide
HHH-3332-again.zip

14/Oct/13 4:53 AM

19 kB

Mihalcea Vlad
HHH-3332-again/.idea/.name 0.0 kB

HHH-3332-again/.idea/compiler.xml 1 kB

HHH-3332-again/.../profiles_settings.xml 0.1 kB

HHH-3332-again/.idea/encodings.xml 0.2 kB

HHH-3332-again/.../Maven__antlr_antlr_2_7_7.xml 0.5 kB

HHH-3332-again/.../Maven__ch_qos_logback_logback_classic_0_9_14.xml 0.6 kB

HHH-3332-again/.../Maven__ch_qos_logback_logback_core_0_9_14.xml 0.5 kB

HHH-3332-again/.../Maven__dom4j_dom4j_1_6_1.xml 0.5 kB

HHH-3332-again/.../Maven__junit_junit_4_5.xml 0.4 kB

HHH-3332-again/.../Maven__org_hibernate_common_hibernate_commons_annotations_4_0_2_Final.xml 0.7 kB

HHH-3332-again/.../Maven__org_hibernate_hibernate_core_4_2_6_Final.xml 0.6 kB

HHH-3332-again/.../Maven__org_hibernate_javax_persistence_hibernate_jpa_2_0_api_1_0_1_Final.xml 0.7 kB

HHH-3332-again/.../Maven__org_hsqldb_hsqldb_2_2_4.xml 0.5 kB

HHH-3332-again/.../Maven__org_javassist_javassist_3_15_0_GA.xml 0.5 kB

HHH-3332-again/.../Maven__org_jboss_logging_jboss_logging_3_1_0_GA.xml 0.6 kB

HHH-3332-again/.../Maven__org_jboss_spec_javax_transaction_jboss_transaction_api_1_1_spec_1_0_1_Final.xml 0.8 kB

HHH-3332-again/.../Maven__org_slf4j_slf4j_api_1_5_6.xml 0.5 kB

HHH-3332-again/.idea/misc.xml 1.0 kB

HHH-3332-again/.idea/modules.xml 0.3 kB

HHH-3332-again/.idea/.../scope_settings.xml 0.1 kB

HHH-3332-again/.idea/uiDesigner.xml 9 kB

HHH-3332-again/.idea/vcs.xml 0.2 kB

HHH-3332-again/.idea/workspace.xml 29 kB

HHH-3332-again/HHH-3332-again.iml 2 kB

HHH-3332-again/pom.xml 2 kB

HHH-3332-again/.../HibernateBagDuplicatesOnMergeTest.java 4 kB

Download Zip
Show

HHH-3332-again.zip

14/Oct/13 4:53 AM

19 kB

Mihalcea Vlad

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Gail Badner added a comment - 19/Jan/11 12:46 PM

Because A is the owner of the relationship, you need to also call:

b.setA( a );

I believe you will still have problems though because of ~~HHH-5732~~.

Please let us know.

Thanks,
Gail

Show

Gail Badner added a comment - 19/Jan/11 12:46 PM Because A is the owner of the relationship, you need to also call: b.setA( a ); I believe you will still have problems though because of HHH-5732 . Please let us know. Thanks, Gail

Hide

Permalink

Seth Martin added a comment - 19/Jan/11 1:01 PM

@Gail
Setting A does not resolve the problem. I have attached the updated test case.

Show

Seth Martin added a comment - 19/Jan/11 1:01 PM @Gail Setting A does not resolve the problem. I have attached the updated test case.

Hide

Permalink

Seth Martin added a comment - 19/Jan/11 1:02 PM

Updated test case to include Gail's suggestion. Does not resolve bug.

Show

Seth Martin added a comment - 19/Jan/11 1:02 PM Updated test case to include Gail's suggestion. Does not resolve bug.

Hide

Permalink

Mike Ressler added a comment - 01/Nov/12 10:54 PM - edited

This still exists on Hibernate 4.1.8. Seems like a pretty critical bug. I've been working around it for some time by inserting into the 0th index - but I'm starting to run into correctness issues. I have other code that would like to operate on a correctly ordered list of "B" (child) elements and I'm unable to give it a correctly ordered list due to this bug.

I've been watching ~~HHH-3332~~, and a comment pointed me here. Definitely still unresolved.

— EDIT: While working to generate a test case relevant to my example, I ended up seeing where my code was at fault. While the bug may or may not still exist, my specific example is not relevant. Cheers!

Show

Mike Ressler added a comment - 01/Nov/12 10:54 PM - edited This still exists on Hibernate 4.1.8. Seems like a pretty critical bug. I've been working around it for some time by inserting into the 0th index - but I'm starting to run into correctness issues. I have other code that would like to operate on a correctly ordered list of "B" (child) elements and I'm unable to give it a correctly ordered list due to this bug. I've been watching HHH-3332 , and a comment pointed me here. Definitely still unresolved. — EDIT: While working to generate a test case relevant to my example, I ended up seeing where my code was at fault. While the bug may or may not still exist, my specific example is not relevant. Cheers!

Hide

Permalink

Petar Tahchiev added a comment - 04/Mar/13 8:53 AM

Yep same thing here. And I'm using 4.1.9.Final

Show

Petar Tahchiev added a comment - 04/Mar/13 8:53 AM Yep same thing here. And I'm using 4.1.9.Final

Hide

Permalink

Martin added a comment - 08/Aug/13 9:35 AM

I'm experiencing the same on 4.2.3.Final

Show

Martin added a comment - 08/Aug/13 9:35 AM I'm experiencing the same on 4.2.3.Final

Hide

Permalink

Mihalcea Vlad added a comment - 14/Oct/13 4:53 AM - edited

I attached this test to prove it still replicates on 4.2.6.Final.

The work-around is to never call merge directly but let the flush/commit synchronizing the changes.
Another work-around is to persist the children prior to calling merge.

Show

Mihalcea Vlad added a comment - 14/Oct/13 4:53 AM - edited I attached this test to prove it still replicates on 4.2.6.Final. The work-around is to never call merge directly but let the flush/commit synchronizing the changes. Another work-around is to persist the children prior to calling merge.

Hide

Permalink

Mike Ressler added a comment - 14/Oct/13 6:08 AM

12 votes and 13 watches over three years. This is one of the longest and most watched issues I've seen.

Show

Mike Ressler added a comment - 14/Oct/13 6:08 AM 12 votes and 13 watches over three years. This is one of the longest and most watched issues I've seen.

People

Assignee:

Unassigned

Reporter:

Seth Martin

Participants:

Gail Badner, Martin, Mihalcea Vlad, Mike Ressler, Petar Tahchiev, Seth Martin

Votes:

14 Vote for this issue

Watchers:

15 Start watching this issue

Dates

Created:

19/Jan/11 11:28 AM

Updated:

14/Oct/13 6:54 AM

Development