boolean is broken on SQLServerDialect

Description

I am upgrading from 3.5.2 to 4.1.9
I am using SQL Server 2000
I have a boolean data type in one of my tables
My schemaupdate fails with the following error.
[SQLServer JDBC Driver][SQLServer]Column or parameter #9: Cannot find data type boolean.

Upon some investigation, i found that SQL Server does not have a boolean type.
Hibernate 3.5.2 used to hardcode the type of boolean to Types.bit in org.hibernate.type.BooleanType.sqlType().
Hibernate 4.1.9 does not do that.

One related bug i found is
https://hibernate.onjira.com/browse/HHH-6420

The commit for this bug is
https://github.com/hibernate/hibernate-orm/commit/d9680adcba4625f6330be7adfebb6fbcd2fb422d

Now in that commit, i don't understand why the following line
registerColumnType( Types.BOOLEAN, "bit" );
was added in SQLServer2005Dialect.java
instead of SQLServerDialect.java

Environment

Hibernate 4.1.9, SQL Server 2000

Status

Assignee

Brett Meyer

Reporter

Himavanth Rachamsetty

Fix versions

backPortable

None

Suitable for new contributors

Yes, likely

Requires Release Note

Affirmative

Pull Request

None

backportDecision

None

Components

Affects versions

Priority

Major
Configure