Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.3.0.Beta2, 4.2.2
    • Component/s: envers
    • Labels:
      None
    • Last commented by a user?:
      true

      Description

      The Gradle OSGi scripting, intro'd in HHH-7941, needs a clear separation of API/SPI and Internal packages in order to create the correct set of Export-Packages and Private-Packages. Anything with ".internal" in it is assumed Private. See core or entitymanager for an example.

      Then, integrate with an OSGi container and correct any issues found.

        Issue Links

          Activity

          Hide
          Brett Meyer added a comment - - edited

          Lukasz Antoniak: I assigned this to you, but let me know if you don't have time or need help – I'm happy to.

          Show
          Brett Meyer added a comment - - edited Lukasz Antoniak : I assigned this to you, but let me know if you don't have time or need help – I'm happy to.
          Hide
          Lukasz Antoniak added a comment -

          The work is mostly done in my forked branch: https://github.com/lukasz-antoniak/hibernate-core/commits/HHH-7944.
          I would like to publish a short migration guide, because org.hibernate.tool.ant.EnversHibernateToolTask has been removed and EnversSchemaGenerator moved to org.hibernate.envers.tool.hbm2ddl package.

          Show
          Lukasz Antoniak added a comment - The work is mostly done in my forked branch: https://github.com/lukasz-antoniak/hibernate-core/commits/HHH-7944 . I would like to publish a short migration guide, because org.hibernate.tool.ant.EnversHibernateToolTask has been removed and EnversSchemaGenerator moved to org.hibernate.envers.tool.hbm2ddl package.
          Hide
          Brett Meyer added a comment -

          Hey Lukasz – thanks again for this. Any update? Need anything from me?

          Show
          Brett Meyer added a comment - Hey Lukasz – thanks again for this. Any update? Need anything from me?
          Hide
          Lukasz Antoniak added a comment -

          Changes pushed to master branch. Brett Meyer, maybe try to run Envers in OSGi container and resolve the ticket if successful.

          Show
          Lukasz Antoniak added a comment - Changes pushed to master branch. Brett Meyer , maybe try to run Envers in OSGi container and resolve the ticket if successful.
          Hide
          Brett Meyer added a comment -

          Thanks Lukasz Antoniak! At first glance, it looks good. However, I won't be able to test it until HHH-7995 is finished. We're not currently able to discover Integrators from optional bundles.

          Show
          Brett Meyer added a comment - Thanks Lukasz Antoniak ! At first glance, it looks good. However, I won't be able to test it until HHH-7995 is finished. We're not currently able to discover Integrators from optional bundles.
          Hide
          Brett Meyer added a comment - - edited

          Thanks Lukasz Antoniak! At first glance, it looks good. However, I won't be able to test it until HHH-7995 is finished. We're not currently able to discover Integrators from optional bundles.

          Simple test bed: https://github.com/brmeyer/HibernateOSGi/commit/deb9566b9cdc6c20ed1fbb02dddc6ebba795cfb8

          Show
          Brett Meyer added a comment - - edited Thanks Lukasz Antoniak ! At first glance, it looks good. However, I won't be able to test it until HHH-7995 is finished. We're not currently able to discover Integrators from optional bundles. Simple test bed: https://github.com/brmeyer/HibernateOSGi/commit/deb9566b9cdc6c20ed1fbb02dddc6ebba795cfb8
          Hide
          Brett Meyer added a comment -

          After adding HHH-7995, wiring OSGi services through blueprint.xml, and a few classloader fixes, this is working well! Lukasz Antoniak, thanks for the help!

          Example usage: https://github.com/brmeyer/HibernateOSGi/commit/744bc87a7989e411ae2ed1bfceb8d52b180a3dd0

          Show
          Brett Meyer added a comment - After adding HHH-7995 , wiring OSGi services through blueprint.xml, and a few classloader fixes, this is working well! Lukasz Antoniak , thanks for the help! Example usage: https://github.com/brmeyer/HibernateOSGi/commit/744bc87a7989e411ae2ed1bfceb8d52b180a3dd0
          Hide
          Brett Meyer added a comment -

          Note that the package refactoring occurred only in master. OSGi services and classloader corrections were made in both master and 4.2.

          Show
          Brett Meyer added a comment - Note that the package refactoring occurred only in master. OSGi services and classloader corrections were made in both master and 4.2.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development