Uploaded image for project: 'Hibernate ORM'
  1. Hibernate ORM
  2. HHH-8363

ClassLoaderServiceImpl should be defined as Stoppable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.3.0.Beta3
    • Fix Version/s: 4.3.0.Beta4, 4.2.6
    • Component/s: None
    • Labels:
      None
    • Bug Testcase Reminder (view):

      Bug reports should generally be accompanied by a test case!

    • Last commented by a user?:
      true

      Description

      There are reports of Hibernate holding on to references of class loaders in a way that is somehow causing that ClassLoader to leak in Wildfly/Jipijapa. The details are a little fuzzy still, but in looking through some of the ServiceRegistry code and specifically the ClassLoaderServiceImpl and its internal AggregatedClassLoader (because of heapdump from Scott Marlow) it seems like this could be caused because ClassLoaderServiceImpl's AggregatedClassLoader does not release the ClassLoader references it holds.

      The heapdump pointed to a class we load from Jipijapa through a JDK ServiceLoader lookup using the AggregatedClassLoader. JDK ServiceLoader does do some caching of the service impls it loads somehow linked to the classloader. java.util.ServiceLoader does provide a way to refresh this cache. But not a way, that I can see, to clear it. Just something else to consider here..

      The idea here is to make ClassLoaderServiceImpl implement Stoppable so that it can receive callback from the ServiceRegistry shutdown process so that it can release these resources.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - Not Specified
                  Not Specified
                  Logged:
                  Time Spent - 8m
                  8m