[SchemaUpdate] javax.persistence.ForeignKey doesn't respect ConstraintMode.NO_CONSTRAINT
Description
is followed up by
relates to
Activity
Yanming Zhou (quaff@github)July 10, 2018 at 10:28 AM
Eclipse will indicate this as "The value of the local variable secondaryTable2 is not used", Much appreciated if hibernate team could eliminate IDE warnings.
Vlad MihalceaJuly 10, 2018 at 8:58 AMEdited
Since I joined the team, we've been adding a replicating test case to every fix so this kind of silly mistakes are prevented.
Nevertheless, after analyzing it, I realized that I was unlikely that someone would add a specific test for @SecondaryTables as this cannot happen with just @SecodnaryTable.
So, it's unfair to put blame on the original committer. If it's code, it will have bugs. Most people don't realize that once they use a certain framework that becomes part of their stack. So, any problem in the framework becomes their problem as well. The whole purpose of OSS is to step in and provide fixes, test cases, etc. Blaming makes no sense either for commercial software or OSS.
Robert RettigJuly 10, 2018 at 8:50 AM
Thanks and I totally agree with your response.
I recognized that hibernate has sophisticated use of findbugs, becaues I needed to rebuild it for myself applying some patches (for playframework) and struggled with those findbugs and clean code rules. They really could find such neve used local variable definitions and reject/error the build process in that case. If you open the file with a modern ide like intellij (maybe eclipse too) it will point that out by default (at least by special color of that variable).
Christian BeikovJuly 10, 2018 at 8:38 AM
Thanks for the fix, I will look into getting this in. There is nobody to blame, bugs happen and get fixed at some point. I guess you don't write bug free software either? Remember, this is an open source project maintained by many individuals and everyone has their own main projects.
Robert RettigJuly 9, 2018 at 4:24 PM
Just asking if someone would reopen that case because of copy paste coding without thinking.
Code reading comprehension training:
what is secondaryTable2 good for?
why this fix is a new bug for a bug?
for ( SecondaryTable secondaryTable2 : secondaryTables.value() ) {Who should we blame for the author or the hibernate code policies? Such code could be easily rejected by a simple rule. Now it is part of hibernate since Date: 4/3/15 12:02 AM.
From that point of view I really understand that no one is doing real legacy database integration work with hibernate, because it is a pain of debugging.
May be interessting for you, this comes from a real application which tries to use secondary tables with no foreignkey generation (it would disturb an legacy application which works on that database too). The many ForeignKey annotations express the desperate attempt to teach hibernate the correct behavior.
Entity
@Table(name = Constants.TABLE_NAME_WORKUNIT)
@SecondaryTables({
@SecondaryTable(
name = Constants.SECONDARY_TABLE_NAME1,
pkJoinColumns = {
@PrimaryKeyJoinColumn(
name = Constants.ID_PRIMARYKEYJOINCOLUMN_STN1,
referencedColumnName = Constants.ID_COLUMN_NAME_TABLE_NAME1,
foreignKey = @ForeignKey(name="none"))
},
foreignKey = @ForeignKey(name="none")),
@SecondaryTable(
name = Constants.SECONDARY_TABLE_NAME2,
pkJoinColumns = {
@PrimaryKeyJoinColumn(
name = Constants.ID_PRIMARYKEYJOINCOLUMN_STN2,
referencedColumnName = Constants.ID_COLUMN_NAME_TABLE_NAME2,
foreignKey = @ForeignKey(name="none"))},
foreignKey = @ForeignKey(name="none")),
@SecondaryTable(
name = Constants.SECONDARY_TABLE_NAME3,
pkJoinColumns = {
@PrimaryKeyJoinColumn(
name = Constants.ID_PRIMARYKEYJOINCOLUMN_STN3,
referencedColumnName = Constants.ID_COLUMN_NAME_TABLE_NAME3,
foreignKey = @ForeignKey(name="none"))
},
foreignKey = @ForeignKey(name="none"))
})
public class WorkUnit...findMatchingSecondaryTable:832, EntityBinder (org.hibernate.cfg.annotations)
setFKNameIfDefined:808, EntityBinder (org.hibernate.cfg.annotations)
bindJoinToPersistentClass:792, EntityBinder (org.hibernate.cfg.annotations)
createPrimaryColumnsToSecondaryTable:786, EntityBinder (org.hibernate.cfg.annotations)
finalSecondaryTableBinding:714, EntityBinder (org.hibernate.cfg.annotations)
doSecondPass:29, SecondaryTableSecondPass (org.hibernate.cfg)
processSecondPasses:1621, InFlightMetadataCollectorImpl (org.hibernate.boot.internal)
processSecondPasses:1586, InFlightMetadataCollectorImpl (org.hibernate.boot.internal)
complete:278, MetadataBuildingProcess (org.hibernate.boot.model.process.spi)
metadata:858, EntityManagerFactoryBuilderImpl (org.hibernate.jpa.boot.internal)
build:885, EntityManagerFactoryBuilderImpl (org.hibernate.jpa.boot.internal)JacobGApril 4, 2016 at 3:21 PM
Actually, it looks like a bug that for bidirectional relationship where one side is mappedBy, you have to use the deprecated Hibernate @ForeignKey on the mapped by side since @JoinColumn is not allowed. Like this:
// parent side
@OneToMany(
cascade = CascadeType.ALL,
fetch = FetchType.LAZY,
mappedBy = "parent",
orphanRemoval = true
)
// do not use a foreign key constraint, because it's not compatible with partitioning.
// needed on both sides of the relationship, but it doesn't look like jpa allows you
// to use @javax.persistence.ForeignKey on the mappedBy side, so we use deprecated hibernate
// version.
@org.hibernate.annotations.ForeignKey(name = "none")
public List<Child> getChildren() {
return _children;
}
// child side
@ManyToOne
@JoinColumn(
// do not use a foreign key constraint, because it's not compatible with partitioning
foreignKey = @ForeignKey(value = ConstraintMode.NO_CONSTRAINT)
)
public Parent getParent() {
return _parent;
}JacobGApril 1, 2016 at 6:29 PM
Wow, I'm using Hibernate 5.0.9, and adding that annotation does not stop the constraint from being created:
@Id
@ManyToOne
@JoinColumn(
name = "some_fk",
foreignKey = @ForeignKey(name = "none", value = ConstraintMode.NO_CONSTRAINT)
)Erick de Oliveira LealFebruary 2, 2016 at 2:37 AM
Oh sorry, I just added name="none" and it does works
@JoinColumn(foreignKey = @javax.persistence.ForeignKey(value = ConstraintMode.NO_CONSTRAINT, name="none") , name = "ID_INTERNO")
Erick de Oliveira LealFebruary 2, 2016 at 2:29 AM
Hibernate 5.0.7 still does it. I had a Firebird DB and trying to migrate to MySQL but I have a lot of shit on DB then I cannot have thiese constraints and Hibernate still creates on MySQL. Please, reopen this issue.
Steve EbersoleMarch 19, 2015 at 7:55 PM
5.0 will be out in Spring as I said above. In fact I hope to start doing pre-releases (Alphas/Betas) in a few weeks.
That said, if anyone wants to work on porting the fix to 4.3 and submitting a pull request feel free...
Petar TahchievMarch 19, 2015 at 3:54 PMEdited
Hmm, interesting.. This seems like breaking of the JPA spec. Does that mean that the TCK is incomplete and didn't verify it?
Details
Assignee
Vlad MihalceaVlad MihalceaReporter
Yanming Zhou (quaff@github)Yanming Zhou (quaff@github)Components
Priority
Major
Details
Details
Assignee
Reporter
Components
Priority
Major
@JoinColumn(foreignKey = @ForeignKey(ConstraintMode.NO_CONSTRAINT))
hibernate will still try to add constraint
2013-12-18 11:25:37,036 localhost-startStop-1 org.hibernate.tool.hbm2ddl.SchemaUpdate ERROR HHH000388: Unsuccessful: alter table oauth_client add constraint FK_43dmxuh3574xhqwmvkt8gdwqf foreign key (owner) references `user` (id)