toLowerCase() still causes bugs in Turkish locale

Description

When hibernate.hbm2ddl.auto is set to validate I get following exception for a boolean column.

I have found the solution. According to this blog post(http://blog.thetaphi.de/2012/07/default-locales-default-charsets-and.html) solution is using toLowerCase(Locale.ROOT) instead of toLowerCase().

Environment

Turkish-Locale tr_TR

Activity

Show:
Steve Ebersole
April 17, 2015, 3:55 PM

I also added a task to add a findbugs check for this condition and fail the build :

BTW, not that some of his logging/exception uses are fine using ROOT rather than ENGLISH as they operate on the arguments to String#format not the message itself...

Brett Meyer
April 17, 2015, 3:44 PM

Awesome, thanks for that – will use it. Note that I'll use ENGLISH in some cases, most notably logs and exception messages.

Onur Şahin
April 17, 2015, 3:33 PM

Have you seen my pull request? I already did that https://github.com/hibernate/hibernate-orm/pull/931

Brett Meyer
April 17, 2015, 3:32 PM

+1 – that would clean up quite a bit.

Brett Meyer
April 17, 2015, 3:31 PM

I'm just going through and correcting every single one...

Fixed

Assignee

Brett Meyer

Reporter

Onur Şahin

Fix versions

Labels

backPortable

None

Suitable for new contributors

None

Requires Release Note

None

backportDecision

None

Priority

Major