Uploaded image for project: 'Hibernate Search'
  1. HSEARCH-2170

Convert the GsonHolder to a Service to ensure cleanup

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.6.0.Beta2
    • Component/s: None
    • Labels:
      None

      Description

      The GsonHolder is a good candidate for a Service as it's unique and stateless, also while it's documented to be threadsafe it is using various ThreadLocal s so we shouldn't hold that in a static reference. Better be safe and avoid references to this on shutdown, especially for applications running Hibernate Search in an EE container.

        Attachments

          Activity

            People

            • Assignee:
              yrodiere Yoann Rodière
              Reporter:
              sanne Sanne Grinovero
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: