Uploaded image for project: 'Hibernate Search'
  1. HSEARCH-2289

DurationBridgeTest assumes an overflow not happening on JDK9

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.6.0.Beta2
    • Component/s: tests
    • Labels:
      None

      Description

      Digged into this test which would fail only on JDK9, to figure out if it was a regression of Java.

      It turns out that DurationBridgeTest.testExceptionValueTooSmall is attempting to force an overflow in the computation of the Duration, however JDK9 is smarter in performing the computation and avoids the overflow (so failing the test).

      So it's not a regression but an improvement.

      It doesn't seem worth to try fooling it in some other way; we could use Byteman but I'd rather remove this test.

        Attachments

          Activity

            People

            • Assignee:
              sanne Sanne Grinovero
              Reporter:
              sanne Sanne Grinovero
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: