method getShardIdentifiersForDeletion in ShardIdentifierProviderTemplate should not be final

Description

The method was introduced with HSEARCH-2075.
It is meant to be overridden (also mentioned in the comment), but the implementation in ShardIdentifierProviderTemplate has the final keyword.

ShardIdentifierProviderTemplate.java

Environment

None

Activity

Show:
Sanne Grinovero
November 15, 2016, 1:39 PM

Thanks ! what a mistake! Fixing right now, should take just a minute..

Yoann Rodière
November 15, 2016, 2:32 PM

Merged just now. The fix will be release in version 5.6.0.Beta4. Thanks!

Assignee

Sanne Grinovero

Reporter

Jelle De Vreese

Labels

None

Suitable for new contributors

Yes, likely

Feedback Requested

None

Fix versions

Priority

Major
Configure