Uploaded image for project: 'Hibernate Search'
  1. HSEARCH-2652

Create one error context per set of works, instead of one per work, when processing Elasticsearch works

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.8.0.Beta3
    • Component/s: elasticsearch
    • Labels:
      None

      Description

      In synchronous mode, it seems we create one error context per (potentially bulked) Elasticsearch work: see org.hibernate.search.elasticsearch.processor.impl.ElasticsearchWorkProcessor.executeSafely(Iterable<ElasticsearchWork<?>>) and org.hibernate.search.elasticsearch.processor.impl.ElasticsearchWorkProcessor.executeSafely(ElasticsearchWork<?>, ElasticsearchWorkExecutionContext).

      We should instead create one error context per set of works that was submitted to the processor, so that the error context can also inform about which tasks were about to be executed, but will not be due to the error.

      Note: we have the exact same issue when performing non-"stream" works in asynchronous mode; see https://github.com/hibernate/hibernate-search/pull/1336#pullrequestreview-29142895

        Attachments

          Activity

            People

            • Assignee:
              yrodiere Yoann Rodière
              Reporter:
              yrodiere Yoann Rodière
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: