Restore option to run WildFly integration tests against manually prepared distribution

Description

introduced option to run WildFly integration tests against manually prepared distribution and to run against built-in Search modules, but over time we seem to lost it.

https://github.com/hibernate/hibernate-search/blob/master/integrationtest/wildfly/README.md

Environment

None

Activity

Show:
Yoann Rodière
August 27, 2018, 2:07 PM

Ok, this definitely wasn't intentional. Could you please share some script that prepares a distribution, and also share the maven command line you are using to execute the Hibernate Search tests? I will try to set up a Jenkins job so that this kind of regression doesn't happen again.

Yoann Rodière
August 27, 2018, 2:10 PM
Edited

Note the options are still there, they just don't work anymore and we didn't notice because we don't have non-regression tests for that.

Martin Simka
August 28, 2018, 11:23 AM

Command we use is:

In older versions it was possible to run tests with useBuiltinModules with default bundled version of Hibernate Search or without useBuiltinModules to let maven copy modules with current version to external WildFly. Patching existing distribution is currently a bit harder with wildfly-server-provisioning-maven-plugin used for WildFly preparation and I don't really need it. I prepared fix for a master that fixes it only with original WildFly distribution (command above). If you agree it's enough I'll submit PR and start working on backport to 5.10.

https://github.com/simkam/hibernate-search/commit/535bb2c4b014b3adfa667cc0432f1d1c7640db50 for master.

Assignee

Martin Simka

Reporter

Martin Simka

Labels

None

Suitable for new contributors

None

Feedback Requested

None

Components

Affects versions

Priority

Major
Configure