Optimize unproxying in indexing processors and reindexing resolvers

Description

Follow-up on HSEARCH-3643: we enabled entity unproxying for every single entity we encounter in the entity tree, but we really only should unproxy entities when it's really necessary, i.e. when we know we will access a private field on the entity.

Environment

None

Activity

Show:
Yoann Rodière
September 5, 2019, 2:40 PM

This is actually pointless. Wherever we currently unproxy entities, we are sure that at some point, we will access properties of the entity, which means the proxy will be initialized.

So it would not be an "optimization" to only unproxy in certain cases: we would only be delaying the inevitable.

Yoann Rodière
September 5, 2019, 2:41 PM

Also, the optimization is rather complex to implement and would certainly introduce a few bugs. Let's avoid that...

Assignee

Yoann Rodière

Reporter

Yoann Rodière

Labels

None

Suitable for new contributors

None

Pull Request

None

Feedback Requested

None

Components

Priority

Major
Configure