HSearch Outbox table module -> inaccesible private field error using Java 9 modules

Description

Hi,

 

I am having some issues with certain fields not being able to be accessed when using Java 9 modules in my project.

 

 

I had a similar issue with Java 9 modules which was fixed earlier.

Activity

Show:

Yoann Rodière October 10, 2022 at 12:24 PM

Right, thanks for reporting this, we should add a few open statements to the module-info of hibernate-search-mapper-orm-coordination-outbox-polling.

I think we need to do that ^ and also add a few tests, because currently we only test a very specific case in the modulepath.

It’s a bit inconvenient to run the main tests in the modulepath (in particular because of test utils), but perhaps we could expand our smoke tests related to the modulepath: instead of just having one test module, integrationtest/java/modules, we’d have several, each with its own set of dependencies, module-info and test:

  • integrationtest/java/modules/orm-elasticsearch (the existing one, renamed)

  • integrationtest/java/modules/orm-lucene (we don’t have a full Java module for backend-lucene, but we define an automatic module name, so this should be possible)

  • integrationtest/java/modules/pojo-standalone-elasticsearch

  • integrationtest/java/modules/pojo-standalone-lucene

  • integrationtest/java/modules/orm-coordination-outbox-polling-elasticsearch (this will check that you solved )

  • integrationtest/java/modules/orm-coordination-outbox-polling-lucene (if it’s easy - it’s a rather exotic combination).

  • And I would stop there for now.

Note that those are smoke tests, so each test class should be fairly simple, basically just checking a roundtrip persist → index → search, with another test checking that Hibernate Search is actually running in the modulepath, just in case. See the existing test, org.hibernate.search.integrationtest.java.modules.service.JavaModulePathIT, for an example.

In the long run we could have more complete smoke tests such as what’s described in , but that will require significantly more work so let’s not do that right now.

Fixed

Assignee

Reporter

Sprint

Affects versions

Priority

Created September 19, 2022 at 10:56 AM
Updated February 2, 2023 at 9:10 AM
Resolved October 19, 2022 at 10:47 AM
Loading...