In GetInstancesFromServiceLoader, do not hide ServiceConfigurationError

Description

In class GetInstancesFromServiceLoader, thrown ServiceConfigurationErrors are not logged:

try {
	instances.add( iterator.next() );
}
catch (ServiceConfigurationError e) {
	// ignore, because it can happen when multiple
	// services are present and some of them are not class loader
	// compatible with our API.
}

There are cases where it would be useful if these were logged after all.
Take for example the case where a developer adding a new ConstraintValidator has made a mistake and has not provided a no-args constructor for the validator. ServiceLoader will in this case fail to load the ConstraintValidator, but this will not be obvious to the developer.

Environment

None

Status

Assignee

Asutosh Pandya

Reporter

Stein Desmet

Labels

core

Worked in

None

Feedback Requested

None

Feedback Requested By

None

backPortable

None

Community Help Wanted

None

Suitable for new contributors

Yes, likely

Requires Release Note

None

Pull Request

https://github.com/hibernate/hibernate-validator/pull/1016

backportDecision

None

backportReEvaluate

None

Components

engine

Fix versions

6.1.0.Alpha3

Affects versions

6.0.14.Final

Priority

Minor