Contention generated on runtime lookup for @GroupSequence annotation

Description

I'm running a benchmark which is highlighting the following contention point:

I'll send a PR as the fix is trivial.

Environment

None

Activity

Show:
Sanne Grinovero
May 3, 2014, 7:31 PM

Attaching the flight recorder output

Hardy Ferentschik
May 4, 2014, 8:02 AM

You are saying it effects 5.1 as well? Is that just a guess or did you actually check? should already address this on master.

Sanne Grinovero
May 5, 2014, 5:36 PM

I don't think it's a duplicate of HV-621, but good point I forgot about ever reporting that. I'll run the benchmark on 5.1 as well, although that implies reproducing the same on WildFly... fingers crossed to not find a different bottleneck which would invalidate these figures.

So far I just guessed it to affect master too as this code didn't seem to have changed.

Hardy Ferentschik
May 5, 2014, 6:02 PM

So far I just guessed it to affect master too as this code didn't seem to have changed.

you need to check where isGroupSequence is called. That has changed on master, pretty much identical to your pull request. The difference is that the Default group is handled specifically in the caller not in isGroupSequence.

Hardy Ferentschik
May 7, 2014, 11:58 AM

Backporting 112e3ed from

Assignee

Sanne Grinovero

Reporter

Sanne Grinovero

Labels

Feedback Requested

None

Feedback Requested By

None

backPortable

None

Suitable for new contributors

None

Pull Request

None

backportDecision

None

backportReEvaluate

None

Components

Fix versions

Affects versions

Priority

Minor
Configure