OSGi metadata is missing optional import for com.thoughtworks.paranamer

Description

If you attempt to use the ParanamerParameterNameProvider introduced by in OSGi you get a NoClassDefFoundError for com.thoughtworks.paranamer.Paranamer even when the paranamer bundle is installed. This is because the hibernate-validator bundle is lacking an optional import for com.thoughtworks.paranamer

Environment

None

Activity

Show:
Gunnar Morling
May 12, 2015, 10:02 AM

I believe we just could add them (unconditionally) to the features file. Should do no harm.

Hardy Ferentschik
May 12, 2015, 11:14 AM

I believe we just could add them (unconditionally) to the features file.

And that works? So specified bundles don't need to be available?

Gunnar Morling
May 12, 2015, 11:32 AM

The features file actually makes them available by adding them to the runtime.

Hardy Ferentschik
May 12, 2015, 11:42 AM

But all the added bundles need the OSGi metadata right? So in the case of paranamer we would need to use wrap:mvn, right?

Gunnar Morling
May 12, 2015, 11:49 AM

Yes, if the Paranamer JAR does not contain a manifest already, we'd have to wrap it. E.g. look here, for the JBoss Logging JAR we amend the manifest a bit (it has a manifest, but there is a small bug in it), whereas for the others we just take the original manifests.

Assignee

Hardy Ferentschik

Reporter

StuartS

Labels

None

Feedback Requested

None

Feedback Requested By

None

backPortable

None

Suitable for new contributors

None

Pull Request

None

backportDecision

None

backportReEvaluate

None

Components

Fix versions

Affects versions

Priority

Minor
Configure