Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Create a dedicated module for the testutils code

Description

Instead of letting the 'engine' module create two artifacts - the main Validator jar, as well as the 'testing' jar (using a qualifier), the testing code should be moved into its own module.

This servers two purposes:

  1. Stick to the Maven rule - one module one artifact

  2. Works around some issues in Intellij where module dependencies are not set-up correctly in case a module depends on two artifacts (the main one as well as one created with a qualifier) of another module.

Environment

None

is followed up by

Activity

Show:

Hardy FerentschikFebruary 23, 2015 at 9:30 AM

But I wouldn't make any promises regarding API stability for that one.

Sure. That's kind of a given. We might want to add something into the code to make it obvious though.

Gunnar MorlingFebruary 20, 2015 at 10:24 PM

Yes, no problem to deploy it. But I wouldn't make any promises regarding API stability for that one. Not that I'd expect many changes, but I wouldn't consider it an "official" API which we deem to keep stable between releases.

Hardy FerentschikFebruary 20, 2015 at 8:07 PM

, I created HV-974. Thanks for the feedback. Only if you guys speak up do we know what and how you use things.

Hardy FerentschikFebruary 20, 2015 at 8:02 PM

I've seen that the 5.2.0.Beta1 version has been released today.
However the new module (org.hibernate:hibernate-validator-test-utils:jar) is not deployed on any artifact repository.
This is due to the fact the maven deploy plugin is configured with the skip option.

Correct.

Partly. I never really saw this module as something which is used outside Validator itself. At least that was never the intention. However, you proof me wrong I guess there is no problem deploying this artifact as well. I'll create a another issue for it. I guess we can just change this with the next release.

CédricDFebruary 20, 2015 at 2:18 PM

Hi Hardy,

I've seen that the 5.2.0.Beta1 version has been released today.
However the new module (org.hibernate:hibernate-validator-test-utils:jar) is not deployed on any artifact repository.
This is due to the fact the maven deploy plugin is configured with the skip option.

Is this skip option really intended ?

In order to test the validation constraints defined in my projects - without having to write the boilerplate coderequired for the assertions - I would like to reuse this artifact !

Kind regards

Fixed

Details

Assignee

Reporter

Participants

CédricD
Gunnar Morling
Hardy Ferentschik

Fix versions

Priority

Created February 13, 2015 at 9:37 AM
Updated July 15, 2015 at 12:12 PM
Resolved February 13, 2015 at 6:42 PM
Loading...