Switch to AssertJ

Description

It's not urgent but it would be nice.
Main reasons:

  • Better error messages

  • API improvements

  • Works with Neo4j, we could remove our existing custom made assertions (maybe and maybe it should be a follow up issue).

If you are a new contributor, this could be a nice solution. Just, please, make sure to contact us for direction before tackling this.

Environment

None

Activity

Show:
Guillaume Smet
May 22, 2018, 2:21 PM

Hi ,

Any progress on this one? https://github.com/hibernate/hibernate-search/pull/1646/files is a good starting point: you basically have to do a replace all for the imports, then you have a few things to fix manually but it shouldn't be too much.

The second step would be to see if we can remove our custom Neo4j assertions in favor of the Neo4j module of Assertj but it can be done as a second step (and in a second PR).

Assignee

Dominik Pieper

Reporter

Davide D'Alto

Labels

None

Feedback Requested

None

Feedback Requested By

None

backPortable

None

Suitable for new contributors

Yes, likely

Pull Request

None

backportDecision

None

backportReEvaluate

None

Components

Fix versions

Priority

Major
Configure