We're updating the issue view to help you get more done. 

Fix some TODOs in OgmEntityPersister

Description

We have a couple of TODOs in OgmEntityPersister due to visibility issues: https://github.com/hibernate/hibernate-ogm/blob/master/core/src/main/java/org/hibernate/ogm/persister/impl/OgmEntityPersister.java#L1382

We might consider fixing the visibility in ORM to avoid having these methods copied.

The methods in ORM should be made protected final so that we don't have to worry about users overriding them.

It would be nice if we could fix this in ORM 5.3 so that the next version of OGM can benefit from it.

(There might be others, the whole file should be checked)

Environment

None

Status

Assignee

Guillaume Smet

Reporter

Guillaume Smet

Labels

None

Worked in

None

Feedback Requested

None

Feedback Requested By

None

backPortable

None

Community Help Wanted

None

Suitable for new contributors

None

Requires Release Note

None

Pull Request

None

backportDecision

None

backportReEvaluate

None

Fix versions

Priority

Major