Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Schema script generated with Persistence.generateSchema() does not include semicolons

Description

Generating a schema script with Persistence.generateSchema() does not include semicolons.

Unlike with org.hibernate.tool.hbm2ddl.SchemaExport, there doesn't seem to be a configuration option to include semicolons when generating the database schema to a script with the JPA API.

A minimal test-case is available on github: https://github.com/bedag/hibernate-schema-generation

Activity

Show:

Adrian Moos May 8, 2017 at 3:11 PM

Sorry, I hadn't realized that the SQL standard specifies statement delimiters to be optional. It seemed such a basic thing to standardize that I never checked whether the standard actually did so ...

Yes, in that case the empty string is an entirely reasonable default, and now I finally understand why the bloody thing is configurable

Steve Ebersole May 8, 2017 at 2:45 PM

Define "safer". That's the problem. You really mean "better for you".

Adrian Moos May 8, 2017 at 2:42 PM

Ah, you mean I should be setting the newly introduced property

properties.put(AvailableSettings.HBM2DDL_DELIMITER, ";");

Ok, that works, though I'd have preferred a safer default than the empty delimiter

Adrian Moos May 5, 2017 at 5:21 PM

The test case Ferdi provided still fails after updating it to newest hibernate:

https://github.com/bedag/hibernate-schema-generation

As an aside, it also fails for Hibernate 5.1.0.Final, so it looks like the linked refactoring was unrelated.

Could I ask you to test future resolutions with the test case we provided?

PS: JIRA prevents me from reopening this issue. Ferdi, can you?

Steve Ebersole February 28, 2016 at 1:13 AM

See

Out of Date

Details

Assignee

Reporter

Labels

Components

Priority

Created November 12, 2015 at 12:31 PM
Updated December 3, 2024 at 9:20 AM
Resolved February 28, 2016 at 1:14 AM