ImplicitCompositeKeyJoinTest#testImplicitCompositeJoin fails due to dialect-specific differences in generated SQL string

Description

ImplicitCompositeKeyJoinTest#testImplicitCompositeJoin fails due to dialect-specific differences in generated SQL string for Oracle, Sybase, and MySQL.

Expected SQL:

create table Employee (age varchar(15) not null, birthday varchar(255) not null, name varchar(20) not null, manager_age varchar(15), manager_birthday varchar(255), manager_name varchar(20), primary key (age, birthday, name))

oracle12c:
create table Employee (age varchar2(15 char) not null, birthday varchar2(255 char) not null, name varchar2(20 char) not null, manager_age varchar2(15 char), manager_birthday varchar2(255 char), manager_name varchar2(20 char), primary key (age, birthday, name))

sybase 15.7
create table Employee (age varchar(15) not null, birthday varchar(255) not null, name varchar(20) not null, manager_age varchar(15) null, manager_birthday varchar(255) null, manager_name varchar(20) null, primary key (age, birthday, name)) lock datarows

mysql 5.7
create table Employee (age varchar(15) not null, birthday varchar(255) not null, name varchar(20) not null, manager_age varchar(15), manager_birthday varchar(255), manager_name varchar(20), primary key (age, birthday, name)) ENGINE=InnoDB

Activity

Show:

Andrea Boriero November 19, 2015 at 11:04 AM

the test checked an issue not related with a specific db, for this reason I think it better not to execute it just for H2.

what about using different expected_sql based on the Dialect?

Former user November 19, 2015 at 5:30 AM

, is there any reason to execute this test on anything other than H2?

Fixed

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Priority

Created November 19, 2015 at 5:28 AM
Updated December 2, 2015 at 5:52 PM
Resolved November 19, 2015 at 3:54 PM