ValidityAuditStrategy not audit properly nested collection with nulls
Activity
Show:
Former user June 23, 2017 at 10:31 PM
Fixed in 5.1 branch as well.
Dmitriy Sulimchuk October 31, 2016 at 5:54 PM
ok
Chris Cranford October 31, 2016 at 4:17 PM
I would need to look into any side effects that could come from changing the comparison logic for component collections when they're mapped differently, e.g. not using OrderColumn or IndexColumn annotations.
In such cases, a simple PK comparison may not be sufficient and would need to be tested.
For the moment, I'll make sure that 5.2.5 will apply the proper IS NULL SQL fragment for this use case so that the validity updates work as intended.
Fixed
Details
Details
Assignee
Chris Cranford
Chris CranfordReporter
Dmitriy Sulimchuk
Dmitriy SulimchukComponents
Affects versions
Priority
CriticalCreated October 31, 2016 at 6:05 AM
Updated June 23, 2017 at 10:31 PM
Resolved June 23, 2017 at 10:31 PM
Problem locate in ValidityAuditStrategy:272 -> here generates predicate that comparing fields with null using "=" sign, but insted must use "is null"
so it cannot set REVEND field
More over i think that checking all fields is not needed, maybe we just can find by primary key(REV, REVTYPE, PRODUCT_ID, ORDER_COL) record where revend is null and set it?