ValidityAuditStrategy not audit properly nested collection with nulls

Description

Problem locate in ValidityAuditStrategy:272 -> here generates predicate that comparing fields with null using "=" sign, but insted must use "is null"
so it cannot set REVEND field
More over i think that checking all fields is not needed, maybe we just can find by primary key(REV, REVTYPE, PRODUCT_ID, ORDER_COL) record where revend is null and set it?

Environment

None

Activity

Show:
Chris Cranford
October 31, 2016, 4:17 PM

I would need to look into any side effects that could come from changing the comparison logic for component collections when they're mapped differently, e.g. not using OrderColumn or IndexColumn annotations.

In such cases, a simple PK comparison may not be sufficient and would need to be tested.

For the moment, I'll make sure that 5.2.5 will apply the proper IS NULL SQL fragment for this use case so that the validity updates work as intended.

Dmitriy Sulimchuk
October 31, 2016, 5:54 PM

ok

Gail Badner
June 23, 2017, 10:31 PM

Fixed in 5.1 branch as well.

Assignee

Chris Cranford

Reporter

Dmitriy Sulimchuk

Fix versions

Labels

None

backPortable

None

Suitable for new contributors

None

Requires Release Note

None

Pull Request

None

backportDecision

None

Components

Affects versions

Priority

Critical
Configure