Lazy properties are not updated on bytecode-enhanced entity if not all lazy properties (e.g. collections) are initialized

I'm running 5.2.10 and I still see an issue.

If an entity has multiple lazy properties but not all of them have been loaded, hasUninitializedLazyProperties() returns true, and then getUpdateStrings() selects the lazy update SQL statement, which does not update any of the lazy properties:

private String[] getUpdateStrings(boolean byRowId, boolean lazy) {
if ( byRowId ) {
return lazy ? getSQLLazyUpdateByRowIdStrings() : getSQLUpdateByRowIdStrings();
}
else {
return lazy ? getSQLLazyUpdateStrings() : getSQLUpdateStrings();
}
}

It seems that there should be a check around here to see if only some of the lazy properties are initialized and others are dirty and activate Dynamic Update:

if ( entry == null && !isMutable() ) {
throw new IllegalStateException( "Updating immutable entity that is not in session yet!" );
}
if ( ( entityMetamodel.isDynamicUpdate() && dirtyFields != null ) ) {
// We need to generate the UPDATE SQL when dynamic-update="true"
propsToUpdate = getPropertiesToUpdate( dirtyFields, hasDirtyCollection );
// don't need to check laziness (dirty checking algorithm handles that)
updateStrings = new String[span];
for ( int j = 0; j < span; j++ ) {
updateStrings[j] = tableUpdateNeeded[j] ?
generateUpdateString( propsToUpdate, j, oldFields, j == 0 && rowId != null ) :
null;
}
}

Thanks for the fix. I'd be very happy if you could backport it to 5.1.x.

Fixed in master.

It seems to be happening because without enableDirtyTracking the dirty checking mechanism used is TypeHelper#findDirty()[1] and it calls [2] which clearly states that for a lazy property to be dirty all lazy properties must be initialized.

[1] - https://github.com/hibernate/hibernate-orm/blob/master/hibernate-core/src/main/java/org/hibernate/type/TypeHelper.java#L298
[2] - https://github.com/hibernate/hibernate-orm/blob/master/hibernate-core/src/main/java/org/hibernate/tuple/AbstractNonIdentifierAttribute.java#L89

This seems to happen only with enableDirtyTracking=false. When it is changed to true, the test passes.

, please take a look at this.