Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Revert query string list parameter expansion changes done in 5.3

Description

I'm integrating with Hibernate and found that 5.3 introduced a few probelms

  • org.hibernate.query.internal.QueryParameterBindingsImpl#expandListValuedParameters changed it's behavior drastically. It causes a side effect i.e. clears the list binding map. so a subsequent call to the method won't return the expanded query string anymore.

  • The constructor visibility of ParameterTranslationsImpl became "default" whereas is was public before. Since this is less critical to me, I'll add this as a separate commit and you can decide what to do with it.

Activity

Show:

Vlad Mihalcea April 5, 2018 at 10:33 AM

Applied PR upstream.

Christian Beikov March 22, 2018 at 8:52 AM

Hey , I just removed the clear part of the parameter list bindings to allow subsequent callers. Seems to work wrt the tests.

Guillaume Smet March 21, 2018 at 9:11 AM

Hi ,

Please be careful when reverting as we also changed the behavior of replacing positional list parameters with positional parameters recently. This part should stay.

We added tests for that so we should be on the safe side.

Fixed

Details

Assignee

Reporter

Fix versions

Priority

Created March 21, 2018 at 7:03 AM
Updated May 5, 2022 at 11:09 AM
Resolved April 5, 2018 at 10:33 AM