@Guillaume Smet Created https://hibernate.atlassian.net/browse/HHH-13113.

it seems very fragile and I don't think it will work, especially once we integrate https://github.com/hibernate/hibernate-orm/pull/2465 .

We will need to pass the additional information to the LimitHandler. Hopefully, it's available somewhere and we can pass it (this needs to be checked).

We would need a default method defaulting to the current one to ensure compatibility.

Could you create a JIRA issue so we can track it?

We will release 5.4.0 in a couple of weeks, it could be a great addition if you think you can work on it.

@Guillaume Smet Couldn't we do something similar to the `LimitHandler` defined in `Oracle8iDialect`, which calls: `sql.trim().toLowerCase(Locale.ROOT).endsWith( " for update" )`: https://github.com/hibernate/hibernate-orm/blob/master/hibernate-core/src/main/java/org/hibernate/dialect/Oracle8iDialect.java#L77.

Maybe something like this?:
```
class Oracle12cLimitHandler extends AbstractLimitHandler {
private static final LimitHandler LEGACY_LIMIT_HANDLER = new Oracle10gDialect().getLimitHandler();

@Override
public boolean supportsLimit () {
return true;
}

@Override
public String processSql (String sql, RowSelection selection) {
LimitHandler limitHandler;
if (sql.trim().toLowerCase(Locale.ROOT).endsWith( " for update" )) {
limitHandler = LEGACY_LIMIT_HANDLER;
} else {
limitHandler = SQL2008StandardLimitHandler.INSTANCE;
}
return limitHandler.processSql(sql, selection);
}
}
```

sure, we are always interested in contributions.

I think the difficulty will be to pass the necessary information to the LimitHandler so that it can know if the statement is a FOR UPDATE statement.

Happy to discuss it further once you have taken a closer look to the code.

There are huge performance gains in Oracle 12c by using fetch first and offset (SQL2008StandardLimitHandler syntax) over rownum for limit handling. Would it make more sense to use the SQL2008StandardLimitHandler for everything besides FOR UPDATE statements? I can submit a PR if you are open to the suggestion.