Gradle plugin causes compile task to be always out of date
Description
Hi,
today I've noticed that the hibernate-gradle-plugin causes compile tasks to be always out of date even if nothing changed. This is caused by a Gradle shortcoming described in https://github.com/gradle/gradle/issues/5510.
Essentially lambdas are not allowed in doLast or doFirst configurations on Java, which the plugin uses though. To workaround this issue we can simply extract the lambda to a dedicated Action. I have a branch ready that I'll attach shortly. Before my fix I've seen the following:
After my changes I see the expected output if nothing changed:
In our case this saves us up to 12 seconds on every run where nothing changed in the java main source - e.g. if only tests changed.
Let me know what you think. Cheers, Christoph
Activity
Nathan XuFebruary 24, 2020 at 2:47 PM
No, they are simply too busy with v6 developing recently. Sooner or later the status will be updated (at least no later than when next version is released).
Christoph DreisFebruary 20, 2020 at 11:59 AM
PR is merged, but the ticket is still open. Am I missing something? Let me know if I can help
Christoph DreisFebruary 19, 2020 at 3:51 PM
See
Christoph DreisFebruary 19, 2020 at 3:24 PM
GitHub is currently having issues when I want to create a PR. I will add it as soon as it’s working again
Hi,
today I've noticed that the hibernate-gradle-plugin causes compile tasks to be always out of date even if nothing changed. This is caused by a Gradle shortcoming described in https://github.com/gradle/gradle/issues/5510.
Essentially lambdas are not allowed in doLast or doFirst configurations on Java, which the plugin uses though. To workaround this issue we can simply extract the lambda to a dedicated Action. I have a branch ready that I'll attach shortly. Before my fix I've seen the following:
After my changes I see the expected output if nothing changed:
In our case this saves us up to 12 seconds on every run where nothing changed in the java main source - e.g. if only tests changed.
Let me know what you think.
Cheers,
Christoph