SequenceHiLoGeneratorNoIncrementTest is not testing the right Optimiser

Description

The `org.hibernate.id.SequenceHiLoGeneratorNoIncrementTest` test seems designed to test `LegacyHiLoAlgorithmOptimizer`, however an initialization failure is triggered making the test actually verify the samantics of the fallback optimizer.

The mistake is best observed by adding a breakpoint in `org.hibernate.id.enhanced.OptimizerFactory#buildOptimizer(java.lang.String, java.lang.Class, int)` .

Unfortunately fixing the test will have it change the asserted values; since the goal of this test is to verify strict consistency with the legacy behaviour we need to be careful.

Activity

Show:
Fixed

Details

Assignee

Reporter

Components

Fix versions

Priority

Created April 27, 2020 at 9:13 PM
Updated April 30, 2020 at 8:16 PM
Resolved April 28, 2020 at 5:17 PM