Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Path for Bug HHH-1493

Description

This a patch for Bug HHH-1493: "mapping.Table fails to add a nullable column"

http://opensource.atlassian.com/projects/hibernate/browse/HHH-1493

Attachments

2

Activity

Show:

Brett Meyer January 23, 2013 at 9:54 PM

This is no longer an issue. This area has been changed quite a bit lately, most notably in HHH-7797. Nullability is handled correctly.

Patrick Decat September 27, 2007 at 5:32 PM

Proper patch against trunk @rev 14028

Patrick Decat September 27, 2007 at 5:28 PM

Here is a proper patch against current trunk@14028 :

Index: /home/pdecat/workspace/eclipse-3.3/hibernate-core-trunk-mapping/Table.java
===================================================================
— /home/pdecat/workspace/eclipse-3.3/hibernate-core-trunk-mapping/Table.java (révision 14028)
+++ /home/pdecat/workspace/eclipse-3.3/hibernate-core-trunk-mapping/Table.java (copie de travail)
@@ -295,15 +295,14 @@
String defaultValue = column.getDefaultValue();
if ( defaultValue != null ) {
alter.append( " default " ).append( defaultValue );
-
- if ( column.isNullable() ) {
- alter.append( dialect.getNullColumnString() );
- }
- else {
- alter.append( " not null" );
- }
-
}
+
+ if ( column.isNullable() ) {
+ alter.append( dialect.getNullColumnString() );
+ }
+ else {
+ alter.append( " not null" );
+ }

boolean useUniqueConstraint = column.isUnique() &&
dialect.supportsUnique() &&

AlexisM February 16, 2006 at 2:54 PM

Search For "// BEGINNING OF PATCH" in the attached file.
Line 252.

Out of Date

Details

Assignee

Reporter

Original estimate

Time tracking

No time logged0.5h remaining

Components

Priority

Created February 16, 2006 at 2:53 PM
Updated January 23, 2013 at 9:54 PM
Resolved January 23, 2013 at 9:54 PM