Hibernate testing adds log4j2, therefore the test case template should use it as well

Description

I created a test case for a previous bug, and it took my some time to figure out why the log4j.properties in the project didn’t do their job.

As hibernate-testing adds log4j2, those weren’t used at all. Instead I needed to add a lo4j2.xml file to get it to work.

Activity

Show:

Alexander Schwartz January 23, 2023 at 4:16 PM

Works for me - thanks!

Yoann Rodière January 23, 2023 at 4:15 PM

Sure. This wasn't a change in the code of Hibernate ORM though, so I can't really assign it to a version and it won't appear anywhere in the changelog.

It's a bit weird, but I think I'll close as rejected, for lack of a better alternative, just to make it clear we didn't actually change Hibernate ORM for this.

Thanks for your PR, though!

Alexander Schwartz January 23, 2023 at 4:08 PM

@yrodiere - as you merged my pull request, can you also close this issue? Thanks.

Alexander Schwartz January 9, 2023 at 8:43 AM

There was a PR https://github.com/hibernate/hibernate-test-case-templates/pull/226 which has already been merged thanks to Yoann.

So I assume this issue can be closed.

Rejected

Details

Assignee

Reporter

Priority

Created December 19, 2022 at 7:00 PM
Updated January 23, 2023 at 4:16 PM
Resolved January 23, 2023 at 4:15 PM