SchemaUpdate/validator doesn't listen to quoting
Description
Attachments
is duplicated by
Activity
Max Rydahl AndersenNovember 6, 2006 at 8:51 PM
thanks for verifying.
...yes, lets hope its only the mysql driver that is weird in this respect.
p.s. hbmlint is also an option here (it gives more info than the current schemavalidator)
Nicklas NordborgNovember 6, 2006 at 5:07 PM
It now works for both MySQL and Postgres. Thank you very much for fixing this. Hope there will be no problem with other JDBC drivers.
Max Rydahl AndersenNovember 6, 2006 at 4:35 PM
I've applied a fix to branch3_2 for mysql. Could you verify on postgres and mysql again ? Thanks.
Max Rydahl AndersenNovember 6, 2006 at 3:24 PM
yes, verified. Either i can't read and understand javadocs or MySQL drivers are lying
DataBaseMetaData.storesMixedCaseQuotedIdentifiers()
DataBaseMetaData.storesUpperCaseQuotedIdentifiers()
DataBaseMetaData.storesLowerCaseQuotedIdentifiers()
all returns true with MySQL and that can't be right - only one should return true.
I'll let MixedCaseQuotedIdentifiers be the one we ask first which should work if other db's at least tell the truth.
Max Rydahl AndersenNovember 6, 2006 at 11:13 AM
Could you report that IllegalArgumentException as a seperate bug with a testcase and do make sure you don't by accident have another hibernate3.jar layong around ?
i'll try and see what mysql problems there is (most likely their driver is lying...have seen that too many times)
The SchemaUpdate only generates SQL with CREATE TABLE statements and can't update existing tables.
With debugging turned on the SchemaUpdate reports:
11:25:22,599 INFO SchemaUpdate:114 - Running hbm2ddl schema update
11:25:22,599 INFO SchemaUpdate:126 - fetching database metadata
.11:25:22,771 INFO SchemaUpdate:142 - updating schema
11:25:22,803 INFO DatabaseMetadata:91 - table not found: AffyFeatures
11:25:22,830 INFO DatabaseMetadata:91 - table not found: AnnotationSets
11:25:22,855 INFO DatabaseMetadata:91 - table not found: AnnotationTypeItems
.... and so on for another 100+ tables
All tables except two exists in the database. The two new tables are created successfully by SchemaUpdate.
I attach one of my mapping files (generated by XDoclet).
I had a quick look at the SchemaUpdate code (which calls DatabaseMetadata) and I think the problem is that it converts the table names to upper or lower case, even though I have quoted them in the mapping files. If the DatabaseMetadata.getTableMetadata could take a Table object as a parameter instead of the name, schema and catalog, it could check the Table.isQuoted() method before converting any names to upper or lower case. It seems like this method is only used by the Configuration class so it shouldn't be too hard to fix.
I could do the fix myself, but I will only be able to validate it against Postgres and MySQL using quoted table names. So, others would probably have to validate it agains other databases and using unquoted table names.