Exception while resuming a transaction is silently eaten

Description

In org.hibernate.engine.transaction.Isolater.JtaDelegate.delegateWork, we find this code:

...
finally {
if ( surroundingTransaction != null ) {
try {
transactionManager.resume( surroundingTransaction );
if ( log.isDebugEnabled() ) {log.debug( "surrounding JTA transaction resumed [" + surroundingTransaction + "]" ); }
} catch( Throwable t ) {
if ( !caughtException ) {
new HibernateException( "unable to resume previously suspended transaction", t );
}
}
}
}

The last line should probably be
throw new HibernateException( "unable to resume previously suspended transaction", t );

  • currently, any exception thrown by resume() will be silently eaten.

Activity

Show:

Steve Ebersole March 21, 2011 at 6:59 PM

Closing stale resolved issues

Emmanuel Bernard April 7, 2006 at 10:14 AM

thanks for pointing this out

Fixed

Details

Assignee

Reporter

Original estimate

Time tracking

No time logged0.5h remaining

Fix versions

Affects versions

Priority

Created April 7, 2006 at 1:08 AM
Updated March 21, 2011 at 6:59 PM
Resolved April 7, 2006 at 10:14 AM